Add type completeness pre-commit hook#16744
Merged
desertaxle merged 2 commits intomainfrom Jan 16, 2025
Merged
Conversation
desertaxle
added
the
development
desertaxle
commented
Jan 16, 2025
Comment on lines
+42
to
+45
| if TYPE_CHECKING: | ||
| StreamHandler = logging.StreamHandler[TextIO] | ||
| else: | ||
| StreamHandler = logging.StreamHandler |
Member
Author
There was a problem hiding this comment.
Added this to ensure the type completeness check is consistent across versions.
CodSpeed Performance ReportMerging #16744 will not alter performanceComparing Summary
|
cicdw
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that
prefectis 100% type complete, this PR adds a pre-commit hook help catch additions to the public API that are missing type hints.This PR also removes the GitHub Actions workflow that was previously performing type completeness checks.
Closes #16292